All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/5] glibc: Fix up minimal build with libc-libm
Date: Wed, 14 Jan 2015 23:27:35 +0000	[thread overview]
Message-ID: <1421278055.31262.41.camel@linuxfoundation.org> (raw)
In-Reply-To: <2d305cab23e64b83ce9a0e0922c24143c4305992.1420843293.git.sgw@linux.intel.com>

On Fri, 2015-01-09 at 14:51 -0800, Saul Wold wrote:
> This addresses 2 issues discovered trying to build a minimal libc with
> libm option.  By default nscd was always being built and without inet
> enabled there were missing symbols.
> 
> The patch got updated changing initgroups to become part of the INET
> group. Newer version of quilt added function information.
> 
> [YOCTO #7108]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  .../glibc/glibc/eglibc-use-option-groups.patch     | 1379 ++++++++++----------
>  meta/recipes-core/glibc/glibc_2.20.bb              |    3 +
>  2 files changed, 693 insertions(+), 689 deletions(-)
> 
> diff --git a/meta/recipes-core/glibc/glibc/eglibc-use-option-groups.patch b/meta/recipes-core/glibc/glibc/eglibc-use-option-groups.patch
> index 7136253..7be9b06 100644
> --- a/meta/recipes-core/glibc/glibc/eglibc-use-option-groups.patch
> +++ b/meta/recipes-core/glibc/glibc/eglibc-use-option-groups.patch
> @@ -4,8 +4,8 @@ Upstream-Status: Pending
>  
>  Index: git/argp/argp-fmtstream.c
>  ===================================================================
> ---- git.orig/argp/argp-fmtstream.c	2014-08-29 20:00:42.976070587 -0700
> -+++ git/argp/argp-fmtstream.c	2014-08-29 20:01:15.188070587 -0700
> +--- git.orig/argp/argp-fmtstream.c
> ++++ git/argp/argp-fmtstream.c
>  @@ -42,6 +42,7 @@
>   #ifdef _LIBC
>   # include <wchar.h>
> @@ -14,7 +14,7 @@ Index: git/argp/argp-fmtstream.c
>   # define __vsnprintf(s, l, f, a) _IO_vsnprintf (s, l, f, a)
>   #endif
>   
> -@@ -100,7 +101,11 @@
> +@@ -100,7 +101,11 @@ __argp_fmtstream_free (argp_fmtstream_t
>     __argp_fmtstream_update (fs);
>     if (fs->p > fs->buf)

Is there a way we could filter out the noise in the patch or move it
into a separate commit? Its rather horrid to review this and I don't
particularly want to backport the noise to dizzy either...

Cheers,

Richard



      parent reply	other threads:[~2015-01-14 23:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 22:51 [PATCH 0/5] Patch and Upgrades Saul Wold
2015-01-09 22:51 ` [PATCH 1/5 v2] usbutils: Add version 008 Saul Wold
2015-01-09 22:51 ` [PATCH 2/5 v2] gnu-efi: Upgrade to 3.0.1 Saul Wold
2015-01-09 22:51 ` [PATCH 3/5] security_flags: disable pie support for libaio, blktrace and ltp Saul Wold
2015-01-14 18:55   ` akuster808
2015-01-14 18:59     ` Saul Wold
2015-01-09 22:51 ` [PATCH 4/5] libaio: Upgrade to 0.3.110 Saul Wold
2015-01-09 22:51 ` [PATCH 5/5] glibc: Fix up minimal build with libc-libm Saul Wold
2015-01-14 18:54   ` akuster808
2015-01-14 19:00     ` Saul Wold
2015-01-14 23:27   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421278055.31262.41.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.