From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] libxl: provide xenlight.pc Date: Thu, 15 Jan 2015 09:33:33 +0000 Message-ID: <1421314413.19103.302.camel@citrix.com> References: <1420813938-23836-1-git-send-email-wei.liu2@citrix.com> <1421151089.19103.43.camel@citrix.com> <21686.41014.686596.666172@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21686.41014.686596.666172@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: jfehlig@suse.com, Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-01-14 at 16:58 +0000, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH] libxl: provide xenlight.pc"): > > On Fri, 2015-01-09 at 14:32 +0000, Wei Liu wrote: > > > A pkg-config file for libxl. It also contains two variables > > > (xenfirmwaredir and libexec_bin) so that tools that are very keen on > > > knowing the locations of Xen binaries (say, libvirt) can use them to > > > determine the location of the binaries. > ... > > This seems like a reasonable thing to provide and the manner which you > > do so seems sane. I've not actually read any pkg-config specs to check > > the content, but it looks plausible: > > Thanks, Ian. (I haven't checked the supplied .pc file.) > > > Acked-by: Ian Campbell > > > > We ought to consider if there are any other libraries we should do this > > for, I think non-stable API ones like libxenctrl/guest should be > > explicitly excluded. > > The obvious one is xenstore. I'm not sure how much we want to > consider that to have a stable API. > > Also, what about libxl users who want to use xentoollog ? I think both of those should be candidates for a .pc file, but that needn't block this patch IMHO. xentoollog could do with moving out of tools/libxc, but ISTR trying that years ago and it turned into a yakk of some sort. Ian.