From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] xen/arm: Update documentation in the public
 header arch-arm.h
Date: Thu, 15 Jan 2015 13:48:59 +0000
Message-ID: <1421329739.5437.10.camel@citrix.com>
References: <1421240029-9478-1-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YBknI-0003wq-JN
	for xen-devel@lists.xenproject.org; Thu, 15 Jan 2015 13:49:04 +0000
In-Reply-To: <1421240029-9478-1-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Keir Fraser <keir@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-01-14 at 12:53 +0000, Julien Grall wrote:
> Minor updates to the documentation in xen/include/public/arch-arm.h:
>     - Comments coding style fix
>     - Typoes
>     - Update the list of supported hypercalls by ARM
>     - Remove uncessary comment about 64bit.

"unnecessary"

> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> 
> ---
>     I'm not sure if we usually backport documentation. If so, I'd like
>     to request backporting for Xen 4.5.

I don't think we need to TBH, any development should be against unstable
and we publish these headers online for ease of access.

> + *   All generic sub-operations
>   *
>   *  HYPERVISOR_domctl
>   *   All generic sub-operations, with the exception of:
> - *    * XEN_DOMCTL_iomem_permission (not yet implemented)
>   *    * XEN_DOMCTL_irq_permission (not yet implemented)
>   *
>   *  HYPERVISOR_sched_op
> @@ -183,7 +178,7 @@
>   * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field
>   * in a struct in memory. On ARM is always 8 bytes sizes and 8 bytes
>   * aligned.
> - * XEN_GUEST_HANDLE_PARAM represent a guest pointer, when passed as an
> + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an
>   * hypercall argument. It is 4 bytes on aarch and 8 bytes on aarch64.

Is there a "32" missing in this last sentence do you think? (not the bit
you touched)

I can fix the "unnecessary" on commit, so:
Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.