From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen/arm: Update documentation in the public header arch-arm.h Date: Thu, 15 Jan 2015 13:59:38 +0000 Message-ID: <1421330378.5437.16.camel@citrix.com> References: <1421240029-9478-1-git-send-email-julien.grall@linaro.org> <1421329739.5437.10.camel@citrix.com> <54B7C65A.7030200@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YBkxz-00050u-Ai for xen-devel@lists.xenproject.org; Thu, 15 Jan 2015 14:00:07 +0000 In-Reply-To: <54B7C65A.7030200@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Keir Fraser , Ian Jackson , tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-01-15 at 13:53 +0000, Julien Grall wrote: > Hi, > > On 15/01/15 13:48, Ian Campbell wrote: > > On Wed, 2015-01-14 at 12:53 +0000, Julien Grall wrote: > >> Minor updates to the documentation in xen/include/public/arch-arm.h: > >> - Comments coding style fix > >> - Typoes > >> - Update the list of supported hypercalls by ARM > >> - Remove uncessary comment about 64bit. > > > > "unnecessary" > > > >> Signed-off-by: Julien Grall > >> Cc: Ian Jackson > >> Cc: Jan Beulich > >> Cc: Keir Fraser > >> > >> --- > >> I'm not sure if we usually backport documentation. If so, I'd like > >> to request backporting for Xen 4.5. > > > > I don't think we need to TBH, any development should be against unstable > > and we publish these headers online for ease of access. > > Ok. I'm fine with that. > > >> + * All generic sub-operations > >> * > >> * HYPERVISOR_domctl > >> * All generic sub-operations, with the exception of: > >> - * * XEN_DOMCTL_iomem_permission (not yet implemented) > >> * * XEN_DOMCTL_irq_permission (not yet implemented) > >> * > >> * HYPERVISOR_sched_op > >> @@ -183,7 +178,7 @@ > >> * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field > >> * in a struct in memory. On ARM is always 8 bytes sizes and 8 bytes > >> * aligned. > >> - * XEN_GUEST_HANDLE_PARAM represent a guest pointer, when passed as an > >> + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an > >> * hypercall argument. It is 4 bytes on aarch and 8 bytes on aarch64. > > > > Is there a "32" missing in this last sentence do you think? (not the bit > > you touched) > > I think yes. Could you fix it when you will commit the patch? Sure. I'll apply it now. > > > I can fix the "unnecessary" on commit, so: > > Acked-by: Ian Campbell > > Thanks, >