From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v1 1/2] tools: unhook blktap1 from the build and remove all references to it Date: Thu, 15 Jan 2015 15:16:04 +0000 Message-ID: <1421334964.3481.8.camel@citrix.com> References: <1421147711.19103.10.camel@citrix.com> <1421147771-22544-1-git-send-email-ian.campbell@citrix.com> <21686.40751.865016.744350@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21686.40751.865016.744350@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-01-14 at 16:54 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH v1 1/2] tools: unhook blktap1 from the build and remove all references to it"): > > This was disabled by default in Xen 4.4. Since xend has now been > > removed from the tree I don't believe anything is using it. > > > > We need to pass an explicit CONFIG_BLKTAP1=n to qemu-xen-traditional > > otherwise it defaults to y and doesn't build. > > > > This patch does all the ground work, the tools/blktap directory will > > be removed in the next (*huge*) patch. > > > > Note that this has no impact on blktap2, which is what libxl supports. > > blktap1 was only usable via xend which has already been removed. > > Acked-by: Ian Jackson Thanks, applied. (I debated doing a pull + adding the acks to the merge, but decided to just rebase and add them in as normal, the result has been build tested again).