From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: [PATCH v2] make error codes a formal part of the ABI
Date: Thu, 15 Jan 2015 16:40:32 +0000
Message-ID: <1421340032.6926.4.camel@eu.citrix.com>
References: <54B7E9E102000078000557AD@mail.emea.novell.com>
	<54B7EA7E.20800@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YBnTx-00044X-DR
	for xen-devel@lists.xenproject.org; Thu, 15 Jan 2015 16:41:17 +0000
In-Reply-To: <54B7EA7E.20800@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-01-15 at 16:27 +0000, Andrew Cooper wrote:
> On 15/01/15 15:25, Jan Beulich wrote:
> 
> > Now that we have two cases where patches against hvmloader got
> > submitted needing to include the hypervisor's errno.h (for the host's
> > system header not necessarily reflecting the correct numbers), take
> > this as a strong sign that we need to make the error return values part
> > of the hypervisor ABI (which de-fact they've always been).
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> How do the non XEN_ prefixed E$FOO get generated with this?  All
> "#define XEN_ERRNO(...)" tokenise XEN_## onto the name.

I thought that too at first, but

+#define XEN_ERRNO(name, value) name = XEN_##name,

adds XEN_ on the value, not the name.

Ian.