Re: [RFCv2 3/6] mac80211: add VHT support for IBSS

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2015-01-16 at 11:38 +0100, Janusz Dziedzic wrote:
> Add VHT80/VHT160 support for IBSS.
> Drivers could activate this feature by
> setting NL80211_FEATURE_VHT_IBSS flag.
> 
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> ---
>  net/mac80211/ibss.c        | 11 +++++++++++
>  net/mac80211/ieee80211_i.h |  2 ++
>  net/mac80211/util.c        | 35 +++++++++++++++++++++++++++++++++++
>  3 files changed, 48 insertions(+)
> 
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index 13b8105..1ffcfab 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -188,6 +188,15 @@ ieee80211_ibss_build_presp(struct ieee80211_sub_if_data *sdata,
>  		 */
>  		pos = ieee80211_ie_build_ht_oper(pos, &sband->ht_cap,
>  						 chandef, 0);
> +
> +		if (chandef->width != NL80211_CHAN_WIDTH_20 &&
> +		    chandef->width != NL80211_CHAN_WIDTH_40 &&
> +		    sband->vht_cap.vht_supported) {
> +			pos = ieee80211_ie_build_vht_cap(pos, &sband->vht_cap,
> +							 sband->vht_cap.cap);
> +			pos = ieee80211_ie_build_vht_oper(pos, &sband->vht_cap,
> +							  chandef);
> +		}
>  	}
>  
>  	if (local->hw.queues >= IEEE80211_NUM_ACS)
> @@ -411,6 +420,8 @@ static void ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
>  		cfg80211_chandef_create(&chandef, cbss->channel, chan_type);
>  		break;
>  	case NL80211_CHAN_WIDTH_40:
> +	case NL80211_CHAN_WIDTH_80:
> +	case NL80211_CHAN_WIDTH_160:
>  		cfg80211_chandef_create(&chandef, cbss->channel,
>  					NL80211_CHAN_WIDTH_20_NOHT);
>  		chandef.width = sdata->u.ibss.chandef.width;

Hmm. Must you not get a chandef from cfg80211 so you don't need this
weird roundtrip through chandef_create()?

Anyway this is more of the discussion on patch 1.

johannes