From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v1 1/3] xen/arm: Add R-Car Gen2 support for early printk Date: Fri, 16 Jan 2015 13:08:44 +0000 Message-ID: <1421413724.19839.62.camel@citrix.com> References: <1421412610-19313-1-git-send-email-oiurii.konovalenko@globallogic.com> <1421412610-19313-2-git-send-email-oiurii.konovalenko@globallogic.com> <54B90C84.5030106@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54B90C84.5030106@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: oleksandr.tyshchenko@globallogic.com, Iurii Konovalenko , stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-16 at 13:05 +0000, Julien Grall wrote: > Hello Iurii, > > Thanks for adding the support of a new board in Xen. > > On 16/01/15 12:50, Iurii Konovalenko wrote: > > diff --git a/xen/include/asm-arm/rcar2-uart.h b/xen/include/asm-arm/rcar2-uart.h > > new file mode 100644 > > index 0000000..10a56fb > > --- /dev/null > > +++ b/xen/include/asm-arm/rcar2-uart.h > > [..] > > > +#ifndef __ASM_ARM_RCAR2_H > > +#define __ASM_ARM_RCAR2_H > > According to the name of the guard should be called __ASM_ARM_RCAR2_UART_H Is RCAR2 the name of the board, the soc or the name of uart IP block? I'd prefer the naming (here and for the main driver) to be as far to the right of that list as possible. Ian.