From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 1/3] xen/arm: vgic: Rename nr_lines into nr_spis Date: Mon, 19 Jan 2015 17:00:50 +0000 Message-ID: <1421686850.10440.164.camel@citrix.com> References: <1421353422-13133-1-git-send-email-julien.grall@linaro.org> <1421353422-13133-2-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDFjR-0002cs-DV for xen-devel@lists.xenproject.org; Mon, 19 Jan 2015 17:03:17 +0000 In-Reply-To: <1421353422-13133-2-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: christoffer.dall@linaro.org, xen-devel@lists.xenproject.org, tim@xen.org, parth.dixit@linaro.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-01-15 at 20:23 +0000, Julien Grall wrote: > The field nr_lines in the arch_domain vgic structure contains the number of > SPIs for the emulated GIC. Using the nr_lines make confusion with the GIC > code, where it means the number of IRQs. This can lead to coding error. > > Also introduce vgic_num_irqs to get the number of IRQ handled by the emulated > GIC. > > Finally drop the initialization of nr_spis in both gicv2v_init and gicv3_init > as it's already initialized in vgic common code. > > Signed-off-by: Julien Grall > Acked-by: Stefano Stabellini Acked + applied.