All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: generate systemd service files only when systemd is available
Date: Tue, 20 Jan 2015 11:58:43 +0000	[thread overview]
Message-ID: <1421755123.10440.243.camel@citrix.com> (raw)
In-Reply-To: <1421754466-3980-1-git-send-email-wei.liu2@citrix.com>

On Tue, 2015-01-20 at 11:47 +0000, Wei Liu wrote:
> Though that's not in any way harmful but it is on the other hand not
> very useful.

It's not 100% clear in the docs that you can call this macro twice, but
it definitely doesn't say you can't so I'd assume it was OK:
Acked-by: Ian Campbell <ian.campbell@citrix.com>

> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  tools/configure.ac | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 113285d..850ba23 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -12,16 +12,6 @@ hotplug/Linux/init.d/sysconfig.xencommons
>  hotplug/Linux/init.d/xen-watchdog
>  hotplug/Linux/init.d/xencommons
>  hotplug/Linux/init.d/xendomains
> -hotplug/Linux/systemd/proc-xen.mount
> -hotplug/Linux/systemd/var-lib-xenstored.mount
> -hotplug/Linux/systemd/xen-init-dom0.service
> -hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
> -hotplug/Linux/systemd/xen-watchdog.service
> -hotplug/Linux/systemd/xenconsoled.service
> -hotplug/Linux/systemd/xendomains.service
> -hotplug/Linux/systemd/xenstored.service
> -hotplug/Linux/systemd/xenstored.socket
> -hotplug/Linux/systemd/xenstored_ro.socket
>  hotplug/Linux/vif-setup
>  hotplug/Linux/xen-backend.rules
>  hotplug/Linux/xen-hotplug-common.sh
> @@ -386,5 +376,21 @@ AC_SUBST(LIBNL3_CFLAGS)
>  fi # ! $rump
>  
>  AX_AVAILABLE_SYSTEMD()
> +
> +AS_IF([test "x$systemd" = "xy"], [
> +    AC_CONFIG_FILES([
> +    hotplug/Linux/systemd/proc-xen.mount
> +    hotplug/Linux/systemd/var-lib-xenstored.mount
> +    hotplug/Linux/systemd/xen-init-dom0.service
> +    hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service
> +    hotplug/Linux/systemd/xen-watchdog.service
> +    hotplug/Linux/systemd/xenconsoled.service
> +    hotplug/Linux/systemd/xendomains.service
> +    hotplug/Linux/systemd/xenstored.service
> +    hotplug/Linux/systemd/xenstored.socket
> +    hotplug/Linux/systemd/xenstored_ro.socket
> +    ])
> +])
> +
>  AC_OUTPUT()
>  

  reply	other threads:[~2015-01-20 11:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 11:47 [PATCH] tools: generate systemd service files only when systemd is available Wei Liu
2015-01-20 11:58 ` Ian Campbell [this message]
2015-01-20 12:07   ` Wei Liu
2015-01-20 12:12     ` Wei Liu
2015-01-20 14:49 ` Ian Jackson
2015-01-20 15:12   ` Wei Liu
2015-01-20 15:19     ` Ian Campbell
2015-01-20 15:37       ` Wei Liu
2015-01-20 15:41         ` Ian Jackson
2015-01-27 17:19           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421755123.10440.243.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.