From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [Patch] static symbols in credit2
Date: Tue, 20 Jan 2015 15:13:01 +0100
Message-ID: <1421763181.30438.10.camel@Abyss.station>
References: <20150114170010.GA15069@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4538843637357856037=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150114170010.GA15069@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Uma Sharma <uma.sharma523@gmail.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4538843637357856037==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-+XQO729ZH3Cj4xS9Gmdw"

--=-+XQO729ZH3Cj4xS9Gmdw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Uma,

AFAICT, this is the second version of the patch, that you produced after
receiving feedback on your first submission, isn't it? In that case, you
should make that evident in the subject, using something like "[PATCH
v2]"

On Wed, 2015-01-14 at 22:30 +0530, Uma Sharma wrote:
> Changing param varibales in sched_credit2.c as static where required.
>=20
> Signed-off-by: Uma Sharma <uma.sharma523@gmail.com>
>=20
> ---
>
And also, you should put a summary of what changed in this new
submission, wrt the previous one(s). We usually put it here, in the
changelog, below the '---' marker.

In this case, that is pretty straightforward, but please do, if only to
get used to it! :-)

> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 1ca521b..9dd8e84 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -163,7 +163,7 @@
>  #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request)
> =20
>=20
> -int opt_migrate_resist=3D500;
> +static int opt_migrate_resist =3D 500;
>  integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
> =20
Sorry for mentioning this only now, but, what about "__read_mostly" as
an attribute (for others too) ?

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-+XQO729ZH3Cj4xS9Gmdw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlS+Ym0ACgkQk4XaBE3IOsRkNACgm106k6iOXS3s1J6fZD26US8H
zeAAn1ZRBnbPf5/1td9M7BCF1522HSFs
=rqfr
-----END PGP SIGNATURE-----

--=-+XQO729ZH3Cj4xS9Gmdw--


--===============4538843637357856037==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4538843637357856037==--