From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools: generate systemd service files only when systemd is available Date: Tue, 20 Jan 2015 15:19:31 +0000 Message-ID: <1421767171.10440.287.camel@citrix.com> References: <1421754466-3980-1-git-send-email-wei.liu2@citrix.com> <21694.27368.62403.68165@mariner.uk.xensource.com> <20150120151204.GD30340@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150120151204.GD30340@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-01-20 at 15:12 +0000, Wei Liu wrote: > On Tue, Jan 20, 2015 at 02:49:12PM +0000, Ian Jackson wrote: > > Wei Liu writes ("[PATCH] tools: generate systemd service files only when systemd is available"): > > > Though that's not in any way harmful but it is on the other hand not > > > very useful. > > > > What is the effect of this in the context of a distro package, where > > the build may occur in a different situation to the installed > > package ? > > > > Not sure if I understand you question but let me try to answer. > > Conceptually speaking for Xen's systemd components to function properly > the service files may need to rely on other components to be built. Where components is things like socket activation support in xenstored etc, I think? Or is there more to it? > If > systemd is not available at build time that means those components which > service files rely on cannot be built, so the service files alone aren't > very useful even if you generate and package them. > > Practically speaking those service files don't depend on any systemd > specific components to be built at the moment so it's harmless to > package them. > > Wei. > > > Ian.