From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 4/4] libxl: Add interface for querying hypervisor about PCI topology Date: Tue, 20 Jan 2015 15:21:08 +0000 Message-ID: <1421767268.10440.289.camel@citrix.com> References: <1420510737-22813-1-git-send-email-boris.ostrovsky@oracle.com> <1420510737-22813-5-git-send-email-boris.ostrovsky@oracle.com> <1421688759.10440.176.camel@citrix.com> <54BE7123.2050808@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54BE7123.2050808@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: keir@xen.org, jbeulich@suse.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, chegger@amazon.com, ufimtseva@gmail.com, wei.liu2@citrix.com, Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On Tue, 2015-01-20 at 10:15 -0500, Boris Ostrovsky wrote: > >> diff --git a/tools/libxl/libxl_linux.c b/tools/libxl/libxl_linux.c > >> index ea5d8c1..07428c0 100644 > >> --- a/tools/libxl/libxl_linux.c > >> +++ b/tools/libxl/libxl_linux.c > >> @@ -279,3 +279,74 @@ libxl_device_model_version libxl__default_device_model(libxl__gc *gc) > >> { > >> return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN; > >> } > >> + > >> +/* These two routines are "inspired" by pciutils */ > > "inspired" in a licensing consistent way? > > pciutils is licensed under GPL2 (e.g. > http://git.kernel.org/cgit/utils/pciutils/pciutils.git/tree/COPYING) so > this would be consistent. libxl is LGPL 2.1 not GPL2, and I'm afraid transitioning code in that direction is not allowed by the license. Ian.