From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] power: max77693: fix simple_return.cocci warnings Date: Wed, 21 Jan 2015 08:59:23 +0100 Message-ID: <1421827163.4420.4.camel@AMDC1943> References: <201501211232.F4NwbEWo%fengguang.wu@intel.com> <20150121041134.GA205386@athens> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:11366 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbbAUH71 (ORCPT ); Wed, 21 Jan 2015 02:59:27 -0500 In-reply-to: <20150121041134.GA205386@athens> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: kbuild test robot Cc: kbuild-all@01.org, Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On =C5=9Bro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote: > drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be= simpified >=20 > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci >=20 > CC: Krzysztof Kozlowski > Signed-off-by: Fengguang Wu > --- >=20 > max77693_charger.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski >=20 > --- a/drivers/power/max77693_charger.c > +++ b/drivers/power/max77693_charger.c > @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 > if (ret) > return ret; > =20 > - ret =3D max77693_set_charge_input_threshold_volt(chg, > + return max77693_set_charge_input_threshold_volt(chg, > chg->charge_input_threshold_volt); > - if (ret) > - return ret; > - > - return 0; > } > =20 > #ifdef CONFIG_OF