From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v2 16/18] Toolstack: Remove Command field for all toolstacks. Date: Wed, 21 Jan 2015 11:49:19 +0000 Message-ID: <1421840959.13271.4.camel@citrix.com> References: <1417536141.29004.6.camel@citrix.com> <1417536299-1810-16-git-send-email-ian.campbell@citrix.com> <21694.41170.882420.107153@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21694.41170.882420.107153@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Jim Fehlig , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-01-20 at 18:39 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v2 16/18] Toolstack: Remove Command field for all toolstacks."): > > Nothing in generic code uses this now, so remove. > > > > xl+xend retain as _Command for internal use only. > > Acked-by: Ian Jackson Thanks. > Although personally I wouldn't bother with the rename. It was mainly to make it easier to grep for all the prexisting uses of {Command} which I was trying to eradicate. With that done perhaps it is redundant, although maybe we want to leave it as _Command so inflight patch series start using it again... Ian.