From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 05/10] xen/arm: vgic-v3: Document the
 current restrictions
Date: Wed, 21 Jan 2015 12:16:51 +0000
Message-ID: <1421842611.13271.20.camel@citrix.com>
References: <1421684957-29884-1-git-send-email-julien.grall@linaro.org>
	<1421684957-29884-6-git-send-email-julien.grall@linaro.org>
	<1421769643.10440.309.camel@citrix.com> <54BE952E.6040304@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YDuDd-0007q1-E6
	for xen-devel@lists.xenproject.org; Wed, 21 Jan 2015 12:17:09 +0000
In-Reply-To: <54BE952E.6040304@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-01-20 at 17:49 +0000, Julien Grall wrote:

> >>     - A processor can only access his own redistributor. For buggy
> >>     assumption, the current code bank the redistributors MMIO.
> > 
> > What assumption? It's not clear if you mean that a foreign redistributor
> > should not be accessible and is, or if it should be accessible and
> > isn't.
> 
> Every redistributor (one per processor) are mapped in distinct MMIO region.
> 
> Unlike the distributor, the redistributor is not banked.

Understood.

> Our current implementation (see vgic_v3_rdistr_mmio_write) consider that
> the redistributor is banked and replicate n-times in the memory.

IOW instead of having e.g. 8 individual redistributors each vcpu sees
it's own redistributor 8 times. That does seem a bit dubious.

> If you give a look to the redistributor iniatialization (see Xen and
> Linux GICv3 code). The code will go through all the redistributors and
> check GICR_TYPER to see if the processor is associated to this
> redistributor.
> 
> I'm not sure how the redistributor should behave if it's accessed by
> another processor.

Please can you find a spec reference and include it in the clarified
version of this item.

> But I'm sure it's wrong to bank it.

Seems likely, but answering the above Q would probably decide this one
way or another too.