From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v4 08/13] Osstest/Debian: Add
 "clk_ignore_unused" to default command line
Date: Wed, 21 Jan 2015 13:12:18 +0000
Message-ID: <1421845938.13271.49.camel@citrix.com>
References: <1421839070.4899.8.camel@citrix.com>
	<1421839094-10857-8-git-send-email-ian.campbell@citrix.com>
	<21695.38204.428700.66771@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21695.38204.428700.66771@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-01-21 at 12:02 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v4 08/13] Osstest/Debian: Add "clk_ignore_unused" to default command line"):
> > dom0 is not aware that some clocks are actually in use (e.g. by the
> > hypervisor), so this stops the kernel from messing with (specifically,
> > disabling) those clocks. It's harmless even when not needed.
> > 
> > Really there ought to be some interface to communicate this from Xen
> > to dom0, or some other mechanism to gate things. See
> > http://bugs.xenproject.org/xen/bug/45
> 
> Actually, despite my email just now acking this: perhaps you could
> gate this on $suite ?
> 
> That way at the very least we'll be prompted every couple of years to
> see if this is still needed.

Sure. Since I know already that this won't be fixed in Jessie I propose
to insert an "if $ho->{Suite} =~ m/wheezy|jessie/;" right from the get
go, as below.

Are you OK with your Ack being retained with that? (I'll mention Jessie
in the commit log too).

Ian.

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index a94f847..aef1b37 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -159,7 +159,9 @@ sub setupboot_uboot ($$$) {
 	# Dom0 specific kernel options
 	my @xenkopt = @kopt;
 	push @xenkopt, $xenkopt;
-	push @xenkopt, "clk_ignore_unused"; # http://bugs.xenproject.org/xen/bug/45
+	# http://bugs.xenproject.org/xen/bug/45
+	push @xenkopt, "clk_ignore_unused"
+	    if $ho->{Suite} =~ m/wheezy|jessie/;
 
 	$xenkopt = join ' ', @xenkopt;
 	logm("Dom0 Linux options: $xenkopt");