All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Lin Kassem <linsara1@gmail.com>
Cc: devel@driverdev.osuosl.org, Larry.Finger@lwfinger.net,
	florian.c.chilhabel@googlemail.com, gregkh@linuxfoundation.org,
	gulsah.1004@gmail.com, shack@linux.com, thomas@grouk.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: fix Missing a blank line after declarations
Date: Wed, 21 Jan 2015 09:04:33 -0800	[thread overview]
Message-ID: <1421859873.10574.17.camel@perches.com> (raw)
In-Reply-To: <20150121144129.GA7195@lin-535U4C>

On Wed, 2015-01-21 at 16:41 +0200, Lin Kassem wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Missing a blank line after declarations

False positives.  Unnecessary changes.

> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
[]
> @@ -129,6 +129,7 @@ struct dvobj_priv {
>  	struct _adapter *padapter;
>  	u32 nr_endpoint;
>  	u8   ishighspeed;
> +
>  	uint(*inirp_init)(struct _adapter *adapter);
>  	uint(*inirp_deinit)(struct _adapter *adapter);
>  	struct usb_device *pusbdev;
> @@ -166,6 +167,7 @@ struct _adapter {
>  	 pid_t evtThread;
>  	struct task_struct *xmitThread;
>  	pid_t recvThread;
> +
>  	uint(*dvobj_init)(struct _adapter *adapter);
>  	void (*dvobj_deinit)(struct _adapter *adapter);
>  	struct net_device *pnetdev;




  reply	other threads:[~2015-01-21 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 14:41 [PATCH] staging: rtl8712: fix Missing a blank line after declarations Lin Kassem
2015-01-21 17:04 ` Joe Perches [this message]
2015-01-21 17:23   ` [PATCH] checkpatch: Add types for other OS typedefs Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421859873.10574.17.camel@perches.com \
    --to=joe@perches.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.chilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gulsah.1004@gmail.com \
    --cc=linsara1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shack@linux.com \
    --cc=thomas@grouk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.