Re: KVM: HAVE_KVM_ARCH_DIRTY_LOG_PROTECT?

[Paul Bolle <pebolle@tiscali.nl>]

On Thu, 2015-01-22 at 14:57 +0100, Paolo Bonzini wrote:
> On 22/01/2015 10:19, Paul Bolle wrote:
> > Your commit ba0513b5b8ff ("KVM: Add generic support for dirty page
> > logging") is included in today's linux-next (ie, next-20150122). I
> > noticed because a script I use to check linux-next spotted a problem
> > with it.
> > 
> > That commit added a Kconfig symbol HAVE_KVM_ARCH_DIRTY_LOG_PROTECT. But
> > nothing in linux-next uses that symbol. Why was it added?
> 
> Ah, there are two Kconfig symbols added by mistake.
> 
> +config HAVE_KVM_ARCH_DIRTY_LOG_PROTECT
> + bool
> +
> +config KVM_GENERIC_DIRTYLOG_READ_PROTECT
> + bool

This one is actually used (so my 800 line perl monster didn't bark):
    $ git grep -n KVM_GENERIC_DIRTYLOG_READ_PROTECT next-20150122
    next-20150122:arch/arm/kvm/Kconfig:27:  select KVM_GENERIC_DIRTYLOG_READ_PROTECT
    next-20150122:arch/arm64/kvm/Kconfig:30:        select KVM_GENERIC_DIRTYLOG_READ_PROTECT
    next-20150122:arch/x86/kvm/Kconfig:42:  select KVM_GENERIC_DIRTYLOG_READ_PROTECT
    next-20150122:virt/kvm/Kconfig:47:config KVM_GENERIC_DIRTYLOG_READ_PROTECT
    next-20150122:virt/kvm/kvm_main.c:998:#ifdef CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT

> Christoffer, can you fix that in kvm-arm and also the other mistake that
> Paul reported?

Thanks,


Paul  Bolle