From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor
	migration support.
Date: Thu, 22 Jan 2015 15:06:35 +0000
Message-ID: <1421939195.23842.33.camel@citrix.com>
References: <1417536141.29004.6.camel@citrix.com>
	<1417536299-1810-12-git-send-email-ian.campbell@citrix.com>
	<21694.41138.137642.85569@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21694.41138.137642.85569@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-01-20 at 18:38 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 12/18] Toolstack: Refactor migration support."):
> > Note that since the previous patch arranges for
> > ts-migration-support-check to continue to fail for libvirt the libvirt
> > code is not actually called yet (and will die if it is). This patch is
> > mainly included to reduce the number of users of
> > toolstack()->{Command} closer to zero.
> ...
> > +sub migrate ($$$$) {
> > +    my ($self,$gho,$dst,$to) = @_;
> > +    my $ho = $self->{Host};
> > +    my $gn = $gho->{Name};
> > +    target_cmd_root($ho,
> > +		    $self->{Command}." migrate $gn $dst",
> > +		    $to);
> > +}
> 
> Again, I think you should pass the $dho rather than the name.  In
> general it's better to pass the hash object to these kind of methods.

For ts-guest-localmigrate is there a cunning stunt you would recommend
to generate a $dho with ->{Name} == "localhost"?

Or perhaps:
        $dho ? $dho->{Name} : "localhost"
? (i.e. $dho==undef => localhost)

Ian.