From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: avoid races related to suspend flow
Date: Fri, 23 Jan 2015 10:54:39 +0100 [thread overview]
Message-ID: <1422006879.2728.19.camel@sipsolutions.net> (raw)
In-Reply-To: <1421962366-7015-1-git-send-email-emmanuel.grumbach@intel.com>
On Thu, 2015-01-22 at 23:32 +0200, Emmanuel Grumbach wrote:
> When we go to suspend, there is complex set of states that
> avoids races. The quiescing variable is set whlie
> __ieee80211_suspend is running. Then suspended is set.
> The code makes sure there is no window without any of these
> flags.
>
> The problem is that workers can still be enqueued while we
> are quiescing. This leads to situations where the driver is
> already suspending and other flows like disassociation are
> handled by a worker.
>
> To fix this, we need to check quiescing and suspended flags
> in the worker itself and not only before enqueueing it.
> I also add here extensive documentation to ease the
> understanding of these complex issues.
Applied.
johannes
prev parent reply other threads:[~2015-01-23 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 21:32 [PATCH] mac80211: avoid races related to suspend flow Emmanuel Grumbach
2015-01-23 9:54 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422006879.2728.19.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.