From: Chris Mason <clm@fb.com>
To: <dsterba@suse.cz>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>,
Miao Xie <miaoxie@huawei.com>, <dsterba@suse.cz>,
<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Don't call btrfs_start_transaction() on frozen fs to avoid deadlock.
Date: Fri, 23 Jan 2015 13:21:57 -0500 [thread overview]
Message-ID: <1422037317.28436.3@mail.thefacebook.com> (raw)
In-Reply-To: <20150123173909.GS13289@twin.jikos.cz>
On Fri, Jan 23, 2015 at 12:39 PM, David Sterba <dsterba@suse.cz> wrote:
> On Wed, Jan 21, 2015 at 03:47:54PM +0800, Qu Wenruo wrote:
>> To David:
>> I'm a little curious about why inode_cache needs to be delayed to
>> next
>> transaction.
>> In btrfs_remount() we have s_umount mutex, and we synced the whole
>> filesystem already,
>> so there should be no running transaction and we can just set any
>> mount
>> option into fs_info.
>
> See our discussion under the noinode_cache option:
>
> https://urldefense.proofpoint.com/v1/url?u=http://www.mail-archive.com/linux-btrfs%2540vger.kernel.org/msg30075.html&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=6%2FL0lzzDhu0Y1hL9xm%2BQyA%3D%3D%0A&m=sv%2BL93W9i7vNsbS3ozpylY3o%2F3wpA4TZTQTtFh3mUXg%3D%0A&s=2d678af317413a7452f047aa9ed07bc7e5424d4bae831ac15fae5f23a2acd080
> https://urldefense.proofpoint.com/v1/url?u=http://www.mail-archive.com/linux-btrfs%2540vger.kernel.org/msg30414.html&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=6%2FL0lzzDhu0Y1hL9xm%2BQyA%3D%3D%0A&m=sv%2BL93W9i7vNsbS3ozpylY3o%2F3wpA4TZTQTtFh3mUXg%3D%0A&s=2fab711b3d70ab27c008694249bc62596f37e41af84dfc21077629930b4fe854
>
>> What do you think about reverting the whole patchset and rework the
>> sysfs interface?
>
> IMO reverting should be the last option, we have a minimal fix to the
> sync deadlock and you've proposed the per-trasaction mount options to
> replace the pending inode_change.
I agree, I'd rather build on top of what we have than use reverts at
this point.
-chris
next prev parent reply other threads:[~2015-01-23 18:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 7:42 [PATCH] btrfs: Don't call btrfs_start_transaction() on frozen fs to avoid deadlock Qu Wenruo
2015-01-19 14:06 ` David Sterba
2015-01-20 2:51 ` Qu Wenruo
2015-01-20 2:53 ` Qu Wenruo
2015-01-20 3:06 ` Miao Xie
2015-01-20 3:17 ` Qu Wenruo
2015-01-20 8:16 ` Miao Xie
2015-01-20 0:19 ` Miao Xie
2015-01-20 0:26 ` Qu Wenruo
2015-01-20 17:13 ` David Sterba
2015-01-21 0:58 ` Qu Wenruo
2015-01-21 1:05 ` Chris Mason
2015-01-21 1:09 ` Qu Wenruo
2015-01-21 1:10 ` Chris Mason
2015-01-21 3:10 ` Miao Xie
2015-01-21 3:15 ` Qu Wenruo
2015-01-21 3:26 ` Miao Xie
2015-01-21 3:53 ` Qu Wenruo
2015-01-21 7:04 ` Miao Xie
2015-01-21 7:47 ` Qu Wenruo
2015-01-21 8:46 ` Miao Xie
2015-01-23 17:39 ` David Sterba
2015-01-23 18:21 ` Chris Mason [this message]
2015-01-23 16:59 ` David Sterba
2015-01-26 0:31 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422037317.28436.3@mail.thefacebook.com \
--to=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.