From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/Makefile: fix qemu-xen-traditional build Date: Mon, 26 Jan 2015 09:55:41 +0000 Message-ID: <1422266141.10967.4.camel@citrix.com> References: <1422200339-1020-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422200339-1020-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Sun, 2015-01-25 at 15:38 +0000, Wei Liu wrote: > In d9740237a ("tools: unhook blktap1 from the build and remove all > references to it"), one spot was left unchanged, which leads to failure > in building qemu-xen-traditional. Well spotted, which make invocation hits this path? make dist (what I test) didn't. > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson Acked-by: Ian Campbell Should we be worried that the -all- and -install- targets are similar but not identical? Specifically one of them lack --extra-cflags? Perhaps we should refactor those so the options are only given ones? > --- > tools/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/Makefile b/tools/Makefile > index 1ad7a5d..5d7a75f 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -158,6 +158,7 @@ qemu-xen-traditional-dir-force-update: qemu-xen-traditional-dir-find > subdir-all-qemu-xen-traditional-dir: qemu-xen-traditional-dir-find > set -e; \ > $(buildmakevars2shellvars); \ > + export CONFIG_BLKTAP1=n; \ > cd qemu-xen-traditional-dir; \ > $(QEMU_ROOT)/xen-setup \ > $(IOEMU_EXTRA_LDFLAGS) \