From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/Makefile: fix qemu-xen-traditional build Date: Mon, 26 Jan 2015 10:06:31 +0000 Message-ID: <1422266791.17434.0.camel@citrix.com> References: <1422200339-1020-1-git-send-email-wei.liu2@citrix.com> <20150126083144.GA6482@aepfle.de> <20150126100111.GA9708@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150126100111.GA9708@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Olaf Hering , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-26 at 10:01 +0000, Wei Liu wrote: > On Mon, Jan 26, 2015 at 09:31:44AM +0100, Olaf Hering wrote: > > On Sun, Jan 25, Wei Liu wrote: > > > > > In d9740237a ("tools: unhook blktap1 from the build and remove all > > > references to it"), one spot was left unchanged, which leads to failure > > > in building qemu-xen-traditional. > > > > Another one. I suspect there is more like that in qemu-xen-traditional. > > Should I spent/waste my time to convert qemu-xen-traditional to handle > > options via configure instead of relying on variables from the Xen > > buildsystem? The same happend when my --prefix series was applied. > > > > qemu-xen-traditional's configure is quite ancient I don't think that's > worth it. It's also not autoconf (neither is mainline qemu's AFAIK), it's just a hand written shell script... Ian.