From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, lkundrak@v3.sk
Subject: Re: [PATCH net] ipv6: replacing a rt6_info needs to purge possible propagated rt6_infos too
Date: Mon, 26 Jan 2015 17:08:36 +0100 [thread overview]
Message-ID: <1422288516.2687.27.camel@stressinduktion.org> (raw)
In-Reply-To: <1422288129.29618.26.camel@edumazet-glaptop2.roam.corp.google.com>
On Mo, 2015-01-26 at 08:02 -0800, Eric Dumazet wrote:
> On Mon, 2015-01-26 at 15:11 +0100, Hannes Frederic Sowa wrote:
> > Lubomir Rintel reported that during replacing a route the interface
> > reference counter isn't correctly decremented.
> >
> > To quote bug <https://bugzilla.kernel.org/show_bug.cgi?id=91941>:
> > | [root@rhel7-5 lkundrak]# sh -x lal
> > | + ip link add dev0 type dummy
> > | + ip link set dev0 up
> > | + ip link add dev1 type dummy
> > | + ip link set dev1 up
> > | + ip addr add 2001:db8:8086::2/64 dev dev0
> > | + ip route add 2001:db8:8086::/48 dev dev0 proto static metric 20
> > | + ip route add 2001:db8:8088::/48 dev dev1 proto static metric 10
> > | + ip route replace 2001:db8:8086::/48 dev dev1 proto static metric 20
> > | + ip link del dev0 type dummy
> > | Message from syslogd@rhel7-5 at Jan 23 10:54:41 ...
> > | kernel:unregister_netdevice: waiting for dev0 to become free. Usage count = 2
> > |
> > | Message from syslogd@rhel7-5 at Jan 23 10:54:51 ...
> > | kernel:unregister_netdevice: waiting for dev0 to become free. Usage count = 2
> >
> > During replacement of a rt6_info we must walk all parent nodes and check
> > if the to be replaced rt6_info got propagated. If so, replace it with
> > an alive one.
> >
> > Reported-by: Lubomir Rintel <lkundrak@v3.sk>
> > Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> Hi Hannes
>
> Was this bug added in commit 4a287eba2de395713d8b2b2aeaa69fa086832d34
> ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support,
> warn about missing CREATE flag") ?
Yes, this patch added the hunk which introduced this problem. Sorry, I
didn't bother to look into git history which patch was responsible,
because I thought it might well be there from the beginning of the
stack.
Fixes: 4a287eba2de3957 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support, warn about missing CREATE flag")
next prev parent reply other threads:[~2015-01-26 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 14:11 [PATCH net] ipv6: replacing a rt6_info needs to purge possible propagated rt6_infos too Hannes Frederic Sowa
2015-01-26 15:36 ` Lubomir Rintel
2015-01-26 16:02 ` Eric Dumazet
2015-01-26 16:08 ` Hannes Frederic Sowa [this message]
2015-01-27 8:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422288516.2687.27.camel@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=eric.dumazet@gmail.com \
--cc=lkundrak@v3.sk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.