From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH v3 07/19] TestSupport: always use xl for generic operations.
Date: Tue, 27 Jan 2015 17:09:28 +0000 [thread overview]
Message-ID: <1422378568.16180.14.camel@citrix.com> (raw)
In-Reply-To: <21703.49006.596653.495026@mariner.uk.xensource.com>
On Tue, 2015-01-27 at 16:40 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH v3 07/19] TestSupport: always use xl for generic operations."):
> > Unless the toolstack is xend (for compatibility with pre-xl Xen
> > versions), when we use xm.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks.
> > For several operations in TestSupport.pm the actual toolstack isn't
> > really relevant, since we want info straight from Xen. For simplicity
> > just use xl (or xm) in these cases, to avoid needing to implement the
> > following specially for each toolstack:
> > - host_get_free_memory
> > - guest_get_state
> > - guest_find_domid
> > - listing assignable pci devices
>
> I think at the very least "guest_get_state" should be implemented
> per-toolstack to exercise the toolstack's query functionality. But
> that's not a blocker for this series.
True. I'll see if I can make that happen for v4.
Ian.
next prev parent reply other threads:[~2015-01-27 17:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 14:34 [PATCH v3 OSSTEST 0/19] Implement for driving libvirt via virsh Ian Campbell
2015-01-26 14:35 ` [PATCH v3 01/19] TestSupport: Add helper to wait for a guest to shutdown Ian Campbell
2015-01-27 16:27 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 02/19] apt: lock osstest's usages of apt-get against each other Ian Campbell
2015-01-27 16:28 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 03/19] ts-logs-capture: Collect some libvirt logs and capabilities Ian Campbell
2015-01-26 14:35 ` [PATCH v3 04/19] Pass host to toolstack() Ian Campbell
2015-01-26 14:35 ` [PATCH v3 05/19] ts-rumpuserxen-demo-xenstorels: Use standard functions for things Ian Campbell
2015-01-26 14:35 ` [PATCH v3 06/19] Toolstack: use get_host_method_object() to manage toolstack selection Ian Campbell
2015-01-26 14:35 ` [PATCH v3 07/19] TestSupport: always use xl for generic operations Ian Campbell
2015-01-27 16:40 ` Ian Jackson
2015-01-27 17:09 ` Ian Campbell [this message]
2015-02-04 14:34 ` Ian Campbell
2015-01-26 14:35 ` [PATCH v3 08/19] TestSupport: guest_create and guest_destroy take only a $gho Ian Campbell
2015-01-27 16:55 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 09/19] Toolstack: Refactor guest lifecycle Ian Campbell
2015-01-27 17:22 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 10/19] Toolstack: Refactor consolecmd handling Ian Campbell
2015-01-27 17:03 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 11/19] Toolstack: Refactor shutdown support Ian Campbell
2015-01-27 17:03 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 12/19] Toolstack: Refactor migration support check Ian Campbell
2015-01-26 14:35 ` [PATCH v3 13/19] Toolstack: Refactor migration support Ian Campbell
2015-01-27 17:12 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 14/19] Toolstack: Refactor save/restore support Ian Campbell
2015-01-27 17:18 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 15/19] libvirt: Implement initscript restart which has some hope of working Ian Campbell
2015-01-27 17:20 ` Ian Jackson
2015-01-26 14:35 ` [PATCH v3 16/19] libvirt: Implement shutdown_wait Ian Campbell
2015-01-26 14:35 ` [PATCH v3 17/19] Toolstack: Remove Command field for all toolstacks Ian Campbell
2015-01-26 14:35 ` [PATCH v3 18/19] ts-guest-start: Use guest_create Ian Campbell
2015-01-27 17:21 ` Ian Jackson
2015-01-28 12:46 ` Ian Campbell
2015-01-26 14:35 ` [PATCH v3 19/19] Toolstack: Pass $gho to create method Ian Campbell
2015-01-27 17:23 ` Ian Jackson
2015-01-28 12:52 ` [PATCH v3 OSSTEST 0/19] Implement for driving libvirt via virsh Ian Campbell
2015-01-28 13:14 ` Ian Jackson
2015-01-28 13:31 ` Ian Campbell
2015-01-28 14:12 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422378568.16180.14.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.