From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] tools/Makefile: fix qemu-xen-traditional
	build
Date: Tue, 27 Jan 2015 17:20:15 +0000
Message-ID: <1422379215.16180.23.camel@citrix.com>
References: <1422200339-1020-1-git-send-email-wei.liu2@citrix.com>
	<1422266141.10967.4.camel@citrix.com>
	<20150126110507.GD24026@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150126110507.GD24026@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-01-26 at 11:05 +0000, Wei Liu wrote:
> On Mon, Jan 26, 2015 at 09:55:41AM +0000, Ian Campbell wrote:
> > On Sun, 2015-01-25 at 15:38 +0000, Wei Liu wrote:
> > > In d9740237a ("tools: unhook blktap1 from the build and remove all
> > > references to it"), one spot was left unchanged, which leads to failure
> > > in building qemu-xen-traditional.
> > 
> > Well spotted, which make invocation hits this path? make dist (what I
> > test) didn't.
> > 
> 
> make -C tools build.
> 
> > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>

And applied.

> > 
> > Should we be worried that the -all- and -install- targets are similar
> > but not identical? Specifically one of them lack --extra-cflags?
> > 
> 
> Perhaps nobody ever provides EXTRA_CFLAGS_QEMU_TRADITIONAL so nobody
> ever trips over that.

Probably true, or at least those people who do use make dist etc.

> > Perhaps we should refactor those so the options are only given ones?
> > 
> 
> This is a good idea. I can do another patch later.

Thanks..