All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Low <jason.low2@hp.com>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
	linux-kernel@vger.kernel.org, aswin@hp.com, jason.low2@hp.com
Subject: Re: [PATCH] cgroup: Initialize root in cgroup_mount
Date: Tue, 27 Jan 2015 09:46:36 -0800	[thread overview]
Message-ID: <1422380796.6710.13.camel@j-VirtualBox> (raw)
In-Reply-To: <20150127161009.GB12314@htj.dyndns.org>

On Tue, 2015-01-27 at 11:10 -0500, Tejun Heo wrote:
> On Mon, Jan 26, 2015 at 04:21:39PM -0800, Jason Low wrote:
> > Compiling kernel/ causes warnings:
> > 
> >     ... ‘root’ may be used uninitialized in this function
> >     ... ‘root’ was declared here
> > 
> > This isn't an issue since there is already logic to not use
> > root if we goto out_unlock without setting root.
> > 
> > Explicitly initialize root to NULL to suppress this so that we can
> > focus on catching warnings that can potentially cause bigger issues.
> 
> Which complier are you using?

Hi Tejun, one of the versions I am seeing this on is gcc 4.6.3.

>   The variable, AFAICS, is always set
> before being deref'd and the function hasn't triggered spurious
> warnings for quite a while with differing versions of gcc.



  reply	other threads:[~2015-01-27 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  0:21 [PATCH] cgroup: Initialize root in cgroup_mount Jason Low
2015-01-27 16:10 ` Tejun Heo
2015-01-27 17:46   ` Jason Low [this message]
2015-01-27 18:18     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422380796.6710.13.camel@j-VirtualBox \
    --to=jason.low2@hp.com \
    --cc=aswin@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.