From: Joe Perches <joe@perches.com>
To: Heba Aamer <heba93aamer@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
notro@tronnes.org, thomas.petazzoni@free-electrons.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] Fix fbtft/fb_pcd8544.c coding style errors
Date: Tue, 27 Jan 2015 12:47:31 -0800 [thread overview]
Message-ID: <1422391651.13127.3.camel@perches.com> (raw)
In-Reply-To: <cover.1422296762.git.heba93aamer@gmail.com>
On Tue, 2015-01-27 at 22:30 +0200, Heba Aamer wrote:
> This patch set fixes most of the checkpatch.pl coding
> style errors found in drivers/staging/fbtft/fb_pcd8544.c
>
> Heba Aamer (6):
> staging: fbtft: fix space required after that ';'
> staging: fbtft: fix spaces required around that '='
> staging: fbtft: fix spaces required around that '<'
I suppose this is OK, but I think it's
better to do all the horizontal whitespace
changes in the same patch.
It's trivial and easy to verify all-at-once
instead of modifying the same line multiple
times.
It's also nice to say that git diff -w shows
no difference and that objdiff is empty.
> staging: fbtft: fix trailing whitespace
prev parent reply other threads:[~2015-01-27 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 20:30 [PATCH 0/6] Fix fbtft/fb_pcd8544.c coding style errors Heba Aamer
2015-01-27 20:33 ` [PATCH 1/6] staging: fbtft: fix space required after that ';' Heba Aamer
2015-01-27 20:35 ` [PATCH 2/6] staging: fbtft: fix spaces required around that '=' Heba Aamer
2015-01-27 20:37 ` [PATCH 3/6] staging: fbtft: fix spaces required around that '<' Heba Aamer
2015-01-27 20:39 ` [PATCH 4/6] staging: fbtft: fix Macros with complex values should be enclosed in parentheses Heba Aamer
2015-01-27 20:42 ` [PATCH 5/6] staging: fbtft: fix do not initialise statics to 0 or NULL Heba Aamer
2015-01-27 20:46 ` [PATCH 6/6] staging: fbtft: fix trailing whitespace Heba Aamer
2015-01-27 20:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422391651.13127.3.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=heba93aamer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=notro@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.