From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] tools/libxl: Correct static pattern rule
 for pkgconfig files
Date: Wed, 28 Jan 2015 10:23:15 +0000
Message-ID: <1422440595.16180.53.camel@citrix.com>
References: <1422390842-4949-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1422390842-4949-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-01-27 at 20:34 +0000, Andrew Cooper wrote:
> Attempting to build libxl causes Make to emit the following warnings
> 
> andrewcoop@andrewcoop:xen.git$ make -C tools/libxl all
> ...
> Makefile:253: target `xenlight.pc' doesn't match the target pattern
> Makefile:253: target `xlutil.pc' doesn't match the target pattern
> ...
> 
> because the static pattern rule is malformed.  'Makefile' as the only
> prereq-pattern does not contain a pattern.
> 
> The rule ends up working because of the use of $@.in where $< should have been
> used, but lacked any dependency between a $FOO.pc and its .in source file.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>

Acked + applied, thanks.