From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC V2 0/5] pvusb toolstack work Date: Wed, 28 Jan 2015 15:51:03 +0000 Message-ID: <1422460263.5187.27.camel@citrix.com> References: <1421656131-19366-1-git-send-email-cyliu@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1421656131-19366-1-git-send-email-cyliu@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chunyan Liu Cc: lars.kurth@citrix.com, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, ian.jackson@citrix.com, caobosimon@gmail.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-01-19 at 16:28 +0800, Chunyan Liu wrote: > This patch series is based on Simon's work. Since there is no progress > after last August, I hope we can make this work proceed. Any comment will > be very appreciated. > > It adds pvusb toolstack implementation, with pvusb kernel side work, > one could attach/detach a usb device to guest. By any chance do you (or anyone else) have a link handy to the design discussions for this stuff around the start of last year? In particular I'm hoping for some reminder on what the libxl_usbctrl_type / libxl_usb_type options mean. Although this is PV USB only I think the intention was to leave a suitable hole for HVM emulated USB support. Or am I mis-remembering? [...] > tools/libxl/Makefile | 2 +- > tools/libxl/libxl.c | 8 +- > tools/libxl/libxl.h | 58 ++ > tools/libxl/libxl_create.c | 41 +- > tools/libxl/libxl_internal.h | 11 + > tools/libxl/libxl_types.idl | 58 +- > tools/libxl/libxl_types_internal.idl | 1 + > tools/libxl/libxl_usb.c | 1277 ++++++++++++++++++++++++++++++++++ > tools/libxl/libxlu_cfg_y.c | 464 ++++++------ > tools/libxl/libxlu_cfg_y.h | 38 +- > tools/libxl/xl.h | 6 + > tools/libxl/xl_cmdimpl.c | 296 +++++++- > tools/libxl/xl_cmdtable.c | 30 + This will need some docs changes too, at least to the xl and xl.cfg manpages. > 13 files changed, 2058 insertions(+), 232 deletions(-) > create mode 100644 tools/libxl/libxl_usb.c >