From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 03/21] libxc: allocate memory with vNUMA information for PV guest Date: Wed, 28 Jan 2015 16:02:43 +0000 Message-ID: <1422460963.5187.33.camel@citrix.com> References: <1422011632-22018-1-git-send-email-wei.liu2@citrix.com> <1422011632-22018-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422011632-22018-4-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ufimtseva@gmail.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-23 at 11:13 +0000, Wei Liu wrote: > + /* Setup dummy vNUMA information if it's not provided. Note > + * that this is a valid state if libxl doesn't provide any > + * vNUMA information. > + * > + * The dummy values make libxc allocate all pages from > + * arbitrary physical. This is the expected behaviour if no ^ nodes ? > + * vNUMA configuration is provided to libxc. > + * > + * Note that the following hunk is just for the convenience of > + * allocation code. No defaulting is happening in libxc. > + */ > + if ( dom->nr_vnuma_info == 0 ) > + { ASSERT(!dom->vnuma_info)? Other than those minor issues/suggestions looks good: Acked-by: Ian Campbell