From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 05/21] libxl: add vmemrange to libxl__domain_build_state Date: Wed, 28 Jan 2015 16:05:06 +0000 Message-ID: <1422461106.5187.35.camel@citrix.com> References: <1422011632-22018-1-git-send-email-wei.liu2@citrix.com> <1422011632-22018-6-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422011632-22018-6-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ufimtseva@gmail.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-23 at 11:13 +0000, Wei Liu wrote: > A vnode consists of one or more vmemranges (virtual memory range). One > example of multiple vmemranges is that there is a hole in one vnode. > > Currently we haven't exported vmemrange interface to libxl user. > Vmemranges are generated during domain build, so we have relevant > structures in domain build state. > > Later if we discover we need to export the interface, those structures > can be moved to libxl_domain_build_info as well. > > These new fields (along with other fields in that struct) are set to 0 > at start of day so we don't need to explicitly initialise them. A > following patch which introduces an independent checking function will > need to access these fields. I don't feel very comfortable squashing > this change into that one so I use a single commit. ^didn't? Acked-by: Ian Campbell