Re: [OSSTEST PATCH 4/4] Insert nested test job name and runvars into

[Ian Campbell <Ian.Campbell@citrix.com>]

On Thu, 2015-01-29 at 10:52 +0000, Ian Campbell wrote:
> On Thu, 2015-01-29 at 10:42 +0000, Wei Liu wrote:
> > On Thu, Jan 29, 2015 at 09:57:43AM +0000, Hu, Robert wrote:
> > [...]
> > > > > diff --git a/mfi-common b/mfi-common
> > > > > index 5c4f5d5..b65f0b5 100644
> > > > > --- a/mfi-common
> > > > > +++ b/mfi-common
> > > > > @@ -166,6 +166,14 @@ create_build_jobs () {
> > > > >                  revision_qemu=$REVISION_QEMU
> > > > \
> > > > >                  revision_qemuu=$REVISION_QEMU_UPSTREAM
> > > > >      fi
> > > > > +    ./cs-job-create $flight build-$arch-hvm build-kern
> > > > \
> > > > > +                arch=$arch kconfighow=xen-enable-xen-config
> > > > \
> > > > > +                $RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS
> > > > $arch_runvars   \
> > > > > +                $suite_runvars
> > > > \
> > > > > +                host_hostflags=$build_hostflags
> > > > \
> > > > > +                revision_linux=v3.16
> > > > \
> > > > > +
> > > > tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> > > > \
> > > > 
> > > > Please don't hard code tree and revision.
> > > > 
> > > > You can specify tree and revision in you test configuration.
> > > Can you help more on details regarding to 'test configuration'? Thanks.
> > 
> > If you look at other tree_linux= in mfi-common, you can see they are
> > assigned to $TREE_LINUX, which is in fact just a shell variable. There
> > are also other variables that you might be interested in, say
> > revision_linux.
> > 
> > If you're using standalone mode, you can specify those variables in
> > .standalone.config then ./standalone-reset. Those trees will then be
> > imported to standalone.db (which is a sqlite3 db) and used during the
> > test.
> > 
> > If you're using production mode, I think there is another way to
> > configure that. I've never setup production mode myself so I cannot say
> > for sure.
> 
> cr-daily-branch sets all this stuff up depending on the branch name and
> they get put into the runvars by make-flight (or the mfi-common helper
> library).
> 
> create_build_jobs already has a load of stuff using tree_linux, I'd
> expect you could just copy it and use the same stuff as L0, unless there
> is some reason for differing? In which case we need to have a
> conversation about what each branch should be testing wrt the L1
> hypervisor and dom0.

... although, did we not decide earlier that the nested test jobs should
reuse the output of the existing build-* jobs, rather than rebuilding?

Ian.