From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning Date: Thu, 29 Jan 2015 12:53:10 +0000 Message-ID: <1422535990.3943.3.camel@citrix.com> References: <1422535788-7466-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGoaw-0006AY-Qw for xen-devel@lists.xenproject.org; Thu, 29 Jan 2015 12:53:14 +0000 In-Reply-To: <1422535788-7466-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-01-29 at 12:49 +0000, Ian Jackson wrote: > $esrow is autovivified as { } by > $candrow->{EquivMostRecentStatus} = $esrow->{status} > so use %$esrow which in scalar context is true iff the > hash is nonempty. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell I'll either push this ontop of the existing queue if that needs restarting for some reason, or along with the libvirt stuff which we discussed would go in next (along with your ap-push linux cleanups) > --- > ts-hosts-allocate-Executive | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive > index 4d5e3bb..7a9411d 100755 > --- a/ts-hosts-allocate-Executive > +++ b/ts-hosts-allocate-Executive > @@ -372,7 +372,7 @@ END > $candrow->{EquivMostRecentStatus} = $esrow->{status}; > print DEBUG "$dbg EQUIV-MOST-RECENT "; > print DEBUG ("$esrow->{flight}.$esrow->{job}". > - " $esrow->{val} $esrow->{status}") if $esrow; > + " $esrow->{val} $esrow->{status}") if %$esrow; > print DEBUG ".\n"; > } >