From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get Date: Thu, 29 Jan 2015 14:46:48 +0000 Message-ID: <1422542848.2091.4.camel@parallels.com> References: <1422486056-11591-1-git-send-email-hch@lst.de> <1422486056-11591-3-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.parallels.com ([199.115.105.18]:58686 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbbA2Orf (ORCPT ); Thu, 29 Jan 2015 09:47:35 -0500 In-Reply-To: <1422486056-11591-3-git-send-email-hch@lst.de> Content-Language: en-US Content-ID: <8A7EE390195A9842B166E27765126AFD@sw.swsoft.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "hch@lst.de" Cc: "linux-scsi@vger.kernel.org" , "bvanassche@acm.org" , "stern@rowland.harvard.edu" T24gVGh1LCAyMDE1LTAxLTI5IGF0IDAwOjAwICswMTAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToNCj4gVGhpcyBlZmZlY3RpdmVseSByZXZlcnRzIGNvbW1pdHMgODViNmM3ICgiW1NDU0ldIHNk OiBmaXggY2FjaGUgZmx1c2hpbmcgb24NCj4gbW9kdWxlIHJlbW92YWwgKGFuZCBpbmRpdmlkdWFs IGRldmljZSByZW1vdmFsKSIgYW5kIGRjNDUxNWVhICgic2NzaTogYWx3YXlzDQo+IGluY3JlbWVu dCByZWZlcmVuY2UgY291bnQiKS4NCj4gDQo+IFdlIG5vdyBuZXZlciBjYWxsIHNjc2lfZGV2aWNl X2dldCBmcm9tIHRoZSBzaHV0ZG93biBwYXRoLCBhbmQgdGhlIGZhY3QNCj4gdGhhdCB3ZSBzdGFy dGVkIGdyYWJiaW5nIHJlZmVyZW5jZSB0aGVyZSBpbiBjb21taXQgODViNmM3IHR1cm5lZCBvdXQN Cj4gdHVybmVkIG91dCB0byBjcmVhdGUgbW9yZSBwcm9ibGVtcyB0aGFuIGl0IHNvbHZlcywgYW5k IHJlcXVpcmVkDQo+IHdvcmthcm91bmRzIGZvciB3b3JrYXJvdW5kcyBmb3Igd29ya2Fyb3VuZHMu IE1vdmUgYmFjayB0byBwcm9wZXJseSBjaGVja2luZw0KPiB0aGUgZGV2aWNlIHN0YXRlIGFuZCBj YXJlZnVsbHkgaGFuZGxlIG1vZHVsZSByZWZjb3VudGluZy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6 IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPg0KPiAtLS0NCj4gIGRyaXZlcnMvc2NzaS9z Y3NpLmMgfCAxNyArKysrKysrKysrLS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zY3Np L3Njc2kuYyBiL2RyaXZlcnMvc2NzaS9zY3NpLmMNCj4gaW5kZXggOWIzODI5OS4uOTVmMDI5MyAx MDA2NDQNCj4gLS0tIGEvZHJpdmVycy9zY3NpL3Njc2kuYw0KPiArKysgYi9kcml2ZXJzL3Njc2kv c2NzaS5jDQo+IEBAIC05ODIsMTUgKzk4MiwxOCBAQCBFWFBPUlRfU1lNQk9MKHNjc2lfcmVwb3J0 X29wY29kZSk7DQo+ICAgKi8NCj4gIGludCBzY3NpX2RldmljZV9nZXQoc3RydWN0IHNjc2lfZGV2 aWNlICpzZGV2KQ0KPiAgew0KPiAtCWlmIChzZGV2LT5zZGV2X3N0YXRlID09IFNERVZfREVMKQ0K PiAtCQlyZXR1cm4gLUVOWElPOw0KPiArCWlmIChzZGV2LT5zZGV2X3N0YXRlID09IFNERVZfREVM IHx8IHNkZXYtPnNkZXZfc3RhdGUgPT0gU0RFVl9DQU5DRUwpDQo+ICsJCWdvdG8gZmFpbDsNCj4g IAlpZiAoIWdldF9kZXZpY2UoJnNkZXYtPnNkZXZfZ2VuZGV2KSkNCj4gLQkJcmV0dXJuIC1FTlhJ TzsNCj4gLQkvKiBXZSBjYW4gZmFpbCB0cnlfbW9kdWxlX2dldCBpZiB3ZSdyZSBkb2luZyBTQ1NJ IG9wZXJhdGlvbnMNCj4gLQkgKiBmcm9tIG1vZHVsZSBleGl0IChsaWtlIGNhY2hlIGZsdXNoKSAq Lw0KPiAtCV9fbW9kdWxlX2dldChzZGV2LT5ob3N0LT5ob3N0dC0+bW9kdWxlKTsNCj4gLQ0KPiAr CQlnb3RvIGZhaWw7DQo+ICsJaWYgKCF0cnlfbW9kdWxlX2dldChzZGV2LT5ob3N0LT5ob3N0dC0+ bW9kdWxlKSkNCj4gKwkJZ290byBmYWlsX3B1dF9kZXZpY2U7DQo+ICAJcmV0dXJuIDA7DQo+ICsN Cj4gK2ZhaWxfcHV0X2RldmljZToNCj4gKwlwdXRfZGV2aWNlKCZzZGV2LT5zZGV2X2dlbmRldik7 DQo+ICtmYWlsOg0KPiArCXJldHVybiAtRU5YSU87DQo+ICB9DQo+ICBFWFBPUlRfU1lNQk9MKHNj c2lfZGV2aWNlX2dldCk7DQoNCklmIHdlIGNhbiBnZXQgYXdheSB3aXRoIHRoaXMsIEknbSBhbGwg Zm9yIHRoaXMgYXBwcm9hY2guICBIb3dldmVyLCB5b3UNCm5lZWQgdG8gZG9jdW1lbnQgaW4gYSBj b21tZW50IG9yIGFib3ZlIHRoZSBmdW5jdGlvbiB0aGF0IGl0IG1heSBub3QgYmUNCmNhbGxlZCBp biBtb2R1bGUgZXhpdCBmdW5jdGlvbnMgYW5kIHdoeS4NCg0KT3RoZXIgdGhhbiB0aGUgY29tbWVu dCBpc3N1ZSwgdGhlIHNlcmllcyBsb29rcyBnb29kLA0KDQpUaGFua3MsDQoNCkphbWVzDQoNCg==