From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andy Grover <agrover@redhat.com>
Cc: linux-scsi@vger.kernel.org, hch@lst.de
Subject: Re: [PATCHv2 3/5] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/linux/scsi.h
Date: Thu, 29 Jan 2015 17:24:13 -0800 [thread overview]
Message-ID: <1422581053.2091.34.camel@HansenPartnership.com> (raw)
In-Reply-To: <1422579397-18696-4-git-send-email-agrover@redhat.com>
On Thu, 2015-01-29 at 16:56 -0800, Andy Grover wrote:
> A great many SCSI codes can be made available to userspace in a uapi
> header, while the kernel-only definitions stay in scsi/scsi.h.
>
> This will permit userspace apps to stop using the antiquated definitions
> available in glibc's scsi/scsi.h, which are very old and incomplete.
>
> scsi/scsi.h also includes uapi/scsi/scsi.h so kernel code need not update
> includes.
>
> Signed-off-by: Andy Grover <agrover@redhat.com>
> ---
> include/scsi/scsi.h | 497 +--------------------------------------------
> include/uapi/linux/Kbuild | 1 +
> include/uapi/linux/scsi.h | 506 ++++++++++++++++++++++++++++++++++++++++++++++
I think this is too much: lots of things in scsi.h have no meaning to
the user: our internal definition of scsi_lun for instance, internal
return codes, mid level queue instructions, our internal markers for
SCSI levels ...
What you put in this file becomes a contract for userspace. The rule
should be don't put anything in unless we want the user to use it (and
we're willing to stick by it).
I really think that nothing that isn't already
in /usr/include/scsi/scsi.h is a great rule to follow and then, if
necessary, justify why any additional stuff.
James
next prev parent reply other threads:[~2015-01-30 1:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 0:56 [PATCHv2 0/5] Move headers to uapi/linux Andy Grover
2015-01-30 0:56 ` [PATCHv2 1/5] scsi: add WRITE_VERIFY_16 to scsi.h Andy Grover
2015-01-30 0:56 ` [PATCHv2 2/5] scsi: Move ioctl defs from scsi/scsi.h to scsi/scsi_ioctl.h Andy Grover
2015-01-30 0:56 ` [PATCHv2 3/5] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/linux/scsi.h Andy Grover
2015-01-30 1:24 ` James Bottomley [this message]
2015-02-02 8:00 ` Christoph Hellwig
2015-01-30 0:56 ` [PATCHv2 4/5] scsi: Move scsi/scsi_ioctl.h to uapi/linux/scsi_ioctl.h Andy Grover
2015-01-30 0:56 ` [PATCHv2 5/5] scsi: move scsi/sg.h to uapi/linux/sg.h Andy Grover
2015-01-30 1:14 ` James Bottomley
2015-01-30 17:28 ` Douglas Gilbert
2015-01-30 18:07 ` Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422581053.2091.34.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=agrover@redhat.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.