From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ilw@linux.intel.com" <ilw@linux.intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [IWLMVM] Firmware restart issue with 3.19-rc6-wl with AC 3160, REV=0x164
Date: Fri, 30 Jan 2015 21:35:11 +0100 [thread overview]
Message-ID: <1422650111.1919.45.camel@sipsolutions.net> (raw)
In-Reply-To: <CAAd0S9BwPQZhOZSzt2NU1SGjzv8i6685Y7Zb6qRQ1BzJ0P92SA@mail.gmail.com> (sfid-20150130_212341_718339_20307764)
On Fri, 2015-01-30 at 21:23 +0100, Christian Lamparter wrote:
> [ 6.274625] iwlwifi 0000:01:00.0: 0x00000038 | BAD_COMMAND
> [ 6.275034] iwlwifi 0000:01:00.0: FW error in SYNC CMD SCD_QUEUE_CFG
WTF. How did the firmware even announce support for this command??
Perhaps I missed it in the log, but which firmware are you using? Any
chance you also upgraded that? Because I can't imagine this code is new
in the tree...
Anyway, make this change:
diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h
index 979ac23522f2..5b8c969f457e 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mvm.h
+++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h
@@ -874,7 +874,7 @@ static inline bool iwl_mvm_is_d0i3_supported(struct iwl_mvm *mvm)
static inline bool iwl_mvm_is_scd_cfg_supported(struct iwl_mvm *mvm)
{
- return mvm->fw->ucode_capa.capa[0] & IWL_UCODE_TLV_API_SCD_CFG;
+ return false;
}
extern const u8 iwl_mvm_ac_to_tx_fifo[];
I guess Emmanuel will look at it on Sunday :)
johannes
next prev parent reply other threads:[~2015-01-30 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 20:23 [IWLMVM] Firmware restart issue with 3.19-rc6-wl with AC 3160, REV=0x164 Christian Lamparter
2015-01-30 20:35 ` Johannes Berg [this message]
2015-01-31 14:16 ` Christian Lamparter
2015-01-31 17:36 ` Grumbach, Emmanuel
2015-01-31 17:57 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422650111.1919.45.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.