From: Joe Perches <joe@perches.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: checkpatch: length of git commit IDs
Date: Sun, 01 Feb 2015 12:35:55 -0800 [thread overview]
Message-ID: <1422822955.12856.7.camel@perches.com> (raw)
In-Reply-To: <20150201213001.06ae0fd7@kant>
On Sun, 2015-02-01 at 21:30 +0100, Stefan Richter wrote:
> On Feb 01 Joe Perches wrote:
> > On Sun, 2015-02-01 at 20:59 +0100, Stefan Richter wrote:
> > > I was just told that 12 is less than 12:
> > >
> > > > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit
> > > > 01234567890ab ("commit description")' #5:
> > > > Commit 2a48fc0ab242 "block: autoconvert trivial BKL users to private
> >
> > Yeah, that message isn't very descriptive.
> >
> > It really wants parentheses around the commit
> > message like:
> >
> > Commit 2a48fc0ab242 ("block: autoconvert trivial BKL users to private
> >
> > Try the version in -next. I think it has a
> > better message description.
>
> Thanks for the tip; this works for me. (checkpatch.pl from current -next
> does actually not complain about the line without parentheses.)
Hmm, I think that should be a defect.
Can you send me your git format-patch output please?
next prev parent reply other threads:[~2015-02-01 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 19:59 checkpatch: length of git commit IDs Stefan Richter
2015-02-01 20:09 ` Joe Perches
2015-02-01 20:30 ` Stefan Richter
2015-02-01 20:35 ` Joe Perches [this message]
2015-02-02 7:24 ` Stefan Richter
2015-02-02 7:30 ` Joe Perches
2015-02-02 8:21 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422822955.12856.7.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.