From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 0/6] xen/arm: Move in/out code to/from init
	section
Date: Mon, 2 Feb 2015 10:58:07 +0000
Message-ID: <1422874687.8361.12.camel@citrix.com>
References: <1421425248-8727-1-git-send-email-julien.grall@linaro.org>
	<54CA7CBB.7050308@linaro.org> <1422617430.12551.9.camel@citrix.com>
	<54CB6C0D.8080007@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YIEhm-0001r2-Vz
	for xen-devel@lists.xenproject.org; Mon, 02 Feb 2015 10:58:11 +0000
In-Reply-To: <54CB6C0D.8080007@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>, Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-01-30 at 11:33 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 30/01/15 11:30, Ian Campbell wrote:
> > On Thu, 2015-01-29 at 18:32 +0000, Julien Grall wrote:
> >> Hello,
> >>
> >> Ping? Any more review for this version of this series?
> > 
> > I was awaiting a version with the declarations in the right places as
> > pointed out by Andy (including his point about definition vs. prototype
> > I'm afraid, which is the style we use).
> 
> I'm not convince about your last point. We have many places (if not all
> on ARM) where __init is used in the header.

Those are mistakes, it seems.

> Some of them was even added by you ;). So I would prefer if we keep
> them, it's more readable. FWIW Linux does it too.

I personally don't particularly care where these things go, but other
hypervisor maintainers seem to and we should aim for the code base to be
consistent where possible.

If we want to change this coding style then we should do that directly
and explicitly, not through the backdoor by just ignoring the policy.

Ian.