From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [OSSTEST PATCH v4 8/9] make-flight: factor out
 do_pv_debian_tests
Date: Mon, 2 Feb 2015 13:18:48 +0000
Message-ID: <1422883128.19293.14.camel@citrix.com>
References: <1418250095-13287-1-git-send-email-wei.liu2@citrix.com>
	<1418250095-13287-9-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1418250095-13287-9-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-12-10 at 22:21 +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  make-flight |   21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/make-flight b/make-flight
> index 9963a46..35904be 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -281,17 +281,24 @@ do_passthrough_tests () {
>    done
>  }
>  
> -test_matrix_do_one () {
> -
> -  # Basic PV Linux test with xl
> +do_pv_debian_test_one () {
> +  toolstack=$1
>  
> -  job_create_test test-$xenarch$kern-$dom0arch-xl test-debian xl \
> +  job_create_test test-$xenarch$kern-$dom0arch-$toolstack test-debian $toolstack \
>              $xenarch $dom0arch                                   \
>              $debian_runvars all_hostflags=$most_hostflags
> +}
>  
> -  job_create_test test-$xenarch$kern-$dom0arch-libvirt test-debian libvirt \
> -            $xenarch $dom0arch                                       \
> -            $debian_runvars all_hostflags=$most_hostflags
> +do_pv_debian_tests () {
> +  for toolstack in xl libvirt; do
> +    do_pv_debian_test_one $toolstack
> +  done
> +}
> +
> +test_matrix_do_one () {
> +
> +  # Basic PV Linux test with xl

This comment isn't true, since libvirt is included too.

Did you confirm no changes to runvars after this change? If so then
please say so in the commit log, then:
Acked-by: Ian Campbell <ian.campbell@citrix.com>

> +  do_pv_debian_tests
>  
>    # No further arm tests at the moment
>    if [ $dom0arch = armhf ]; then