From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [OSSTEST PATCH v4 3/9] ts-xen-build: build with XSM
 support if requested
Date: Mon, 2 Feb 2015 14:51:58 +0000
Message-ID: <1422888718.19293.44.camel@citrix.com>
References: <1418250095-13287-1-git-send-email-wei.liu2@citrix.com>
	<1418250095-13287-4-git-send-email-wei.liu2@citrix.com>
	<1422882874.19293.10.camel@citrix.com>
	<20150202143048.GA2743@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150202143048.GA2743@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-02-02 at 14:30 +0000, Wei Liu wrote:
> On Mon, Feb 02, 2015 at 01:14:34PM +0000, Ian Campbell wrote:
> > On Wed, 2014-12-10 at 22:21 +0000, Wei Liu wrote:
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > Inconsistent whitespace in the final hunk, but:
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > This will override the default XSM_ENABLE always, even if no runvar is
> > present, I guess we think that is correct?
> > 
> 
> I'm not sure what's correct. I originally treated it as the same as
> debug=. But now since there is doubt about what is the correct behaviour
> I will make it only set XSM_ENABLE when runvar is set in next version.

That's probably going to have the least potential to be problematic in
the future.

Ian.