From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 1/2] xen/arm: vgic: Keep track of vIRQ used by a domain Date: Mon, 2 Feb 2015 15:09:53 +0000 Message-ID: <1422889793.4801.13.camel@citrix.com> References: <1422546694-22797-1-git-send-email-julien.grall@linaro.org> <1422546694-22797-2-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YIIdS-0003H8-U0 for xen-devel@lists.xenproject.org; Mon, 02 Feb 2015 15:09:59 +0000 In-Reply-To: <1422546694-22797-2-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: christoffer.dall@linaro.org, xen-devel@lists.xenproject.org, tim@xen.org, parth.dixit@linaro.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-01-29 at 15:51 +0000, Julien Grall wrote: > - Move the retry after looking for first/end. I keep the goto > rather than a loop because it's more clear that we retry because > we were unable to set the bit Then I think a "do {} while (!successfully allocated)" is what is wanted, maybe with a comment. Ian.