From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Julien Grall <julien.grall@linaro.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/libxc: Don't leave scratch_pfn uninitialised if the domain has no memory
Date: Mon, 2 Feb 2015 15:26:37 +0000 [thread overview]
Message-ID: <1422890797.5695.6.camel@citrix.com> (raw)
In-Reply-To: <1422460355-16163-1-git-send-email-andrew.cooper3@citrix.com>
On Wed, 2015-01-28 at 15:52 +0000, Andrew Cooper wrote:
> c/s 5b5c40c0d1 "libxc: introduce a per architecture scratch pfn for temporary
> grant mapping" accidentally an issue whereby there were two paths out of
> xc_core_arch_get_scratch_gpfn() which returned 0, but only one of which
> assigned a value to the gpfn parameter.
>
> xc_domain_maximum_gpfn() can validly return 0, at which point gpfn 1 is a
> valid scratch page to use.
>
> In addition, widen rc before adding 1 and possibly overflowing.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Julien Grall <julien.grall@linaro.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
Acked + applied, thanks.
next prev parent reply other threads:[~2015-02-02 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 13:25 [PATCH v2] libxc: introduce a per architecture scratch pfn for temporary grant mapping Julien Grall
2015-01-21 16:42 ` Andrew Cooper
2015-01-27 17:18 ` Ian Campbell
2015-01-27 18:22 ` Ian Jackson
2015-02-16 14:49 ` Ian Jackson
2015-01-28 15:52 ` [PATCH] tools/libxc: Don't leave scratch_pfn uninitialised if the domain has no memory Andrew Cooper
2015-01-29 18:35 ` Julien Grall
2015-01-30 0:17 ` Andrew Cooper
2015-02-02 15:26 ` Ian Campbell [this message]
2015-02-16 14:57 ` [PATCH v2] libxc: introduce a per architecture scratch pfn for temporary grant mapping Andrew Cooper
2015-03-03 17:41 ` [PATCH] tools/libxc: Don't leave scratch_pfn uninitialised if the domain has no memory [and 3 more messages] Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422890797.5695.6.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@linaro.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.