From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 15/15] xen/arm: gic-v3: Update some
 comments in the code
Date: Mon, 2 Feb 2015 16:05:50 +0000
Message-ID: <1422893150.5838.26.camel@citrix.com>
References: <1422555950-31821-1-git-send-email-julien.grall@linaro.org>
	<1422555950-31821-16-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YIJVc-0004B9-2j
	for xen-devel@lists.xenproject.org; Mon, 02 Feb 2015 16:05:56 +0000
In-Reply-To: <1422555950-31821-16-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, Vijaya.Kumar@caviumnetworks.com, stefano.stabellini@citrix.com, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-01-29 at 18:25 +0000, Julien Grall wrote:
>     - Drop wrong comment about the default stride. It's not always 2 * SZ_64K

What other defaults are possible and under what circumstances?

>     - Explain why SZ_64K * 2
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> ---
>     Changes in v2:
>         - Patch added
> ---
>  xen/arch/arm/gic-v3.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 1b7ddb3..9035e3b 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -638,7 +638,7 @@ static int __init gicv3_populate_rdist(void)
>                  ptr += gicv3.rdist_stride;
>              else
>              {
> -                ptr += SZ_64K * 2;
> +                ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */
>                  if ( typer & GICR_TYPER_VLPIS )
>                      ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
>              }
> @@ -1238,7 +1238,6 @@ static int __init gicv3_init(struct dt_device_node *node, const void *data)
>          rdist_regs[i].size = rdist_size;
>      }
>  
> -    /* If stride is not set in dt. Set default to 2 * SZ_64K */
>      if ( !dt_property_read_u32(node, "redistributor-stride", &gicv3.rdist_stride) )
>          gicv3.rdist_stride = 0;
>