From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 11/15] xen/arm: vgic-v2: Correctly handle RAZ/WI registers Date: Mon, 2 Feb 2015 16:50:51 +0000 Message-ID: <1422895851.5838.34.camel@citrix.com> References: <1422555950-31821-1-git-send-email-julien.grall@linaro.org> <1422555950-31821-12-git-send-email-julien.grall@linaro.org> <1422892959.5838.23.camel@citrix.com> <54CFA774.3010904@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YIKDC-0000kQ-Ks for xen-devel@lists.xenproject.org; Mon, 02 Feb 2015 16:50:58 +0000 In-Reply-To: <54CFA774.3010904@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, Vijaya.Kumar@caviumnetworks.com, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-02-02 at 16:36 +0000, Julien Grall wrote: > Hi Ian, > > On 02/02/15 16:02, Ian Campbell wrote: > > On Thu, 2015-01-29 at 18:25 +0000, Julien Grall wrote: > >> Some of the registers are accessible via multiple size (see GICD_IPRIORITYR*). > > > > They are byte accessible, but are they half word accessible? I suspect > > not. > > Only byte accessible. I think we might need a read_as_zero_8_32 then, i.e. explicitly list the sizes which are allowed, and perhaps omit the un-suffixed version for so it's clear exactly what is what, although that might be more churn than you want to have here. Ian.