From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] phy: qcom-ufs: export symbols needed by main drivers Date: Mon, 2 Feb 2015 17:55:48 +0000 Message-ID: <1422899790.2103.11.camel@parallels.com> References: <1840882.huchmEIh5K@wuerfel> <1422891069.2103.1.camel@parallels.com> <20150202162648.GA20465@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.parallels.com ([199.115.105.18]:47408 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932424AbbBBR4h (ORCPT ); Mon, 2 Feb 2015 12:56:37 -0500 In-Reply-To: <20150202162648.GA20465@lst.de> Content-Language: en-US Content-ID: <951A533B38FB4445B2A90C0C65CDE3A1@sw.swsoft.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "hch@lst.de" Cc: "linux-arm-kernel@lists.infradead.org" , "dovl@codeaurora.org" , "ygardi@codeaurora.org" , "kishon@ti.com" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "linux-scsi@vger.kernel.org" T24gTW9uLCAyMDE1LTAyLTAyIGF0IDE3OjI2ICswMTAwLCBoY2hAbHN0LmRlIHdyb3RlOg0KPiBP biBNb24sIEZlYiAwMiwgMjAxNSBhdCAwMzozMDoyN1BNICswMDAwLCBKYW1lcyBCb3R0b21sZXkg d3JvdGU6DQo+ID4gQ2MgYWRkZWQgZm9yIGxpbnV4LXNjc2ksIHNpbmNlIHRoaXMgaXMgdGhlIG9y aWdpbiBvZiB0aGUgcHJvYmxlbS4gIEhvdw0KPiA+IGltcG9ydGFudCBpcyBiaXNlY3RhYmlsaXR5 IGluIHRoaXM/ICBJdCB3b24ndCBhZmZlY3QgYW55IG5vbi1lbWJlZGRlZA0KPiA+IHVzZXIsIHNp bmNlIG1vc3QgZG9uJ3QgYnVpbGQgd2l0aCBVRlMsIHNvIEkgY2FuIGdvIGVpdGhlciB3YXkgb24g Zm9sZGluZw0KPiA+IG9yIGp1c3QgYXBwbHlpbmcgYXMgYW4gZXh0cmEgcGF0Y2guDQo+IA0KPiBU aGUgQ1JZUFRPX0RFVl9RQ09NX0lDRSBzeW1ib2wgd2FzIG5ldmVyIGRlZmluZWQgaW4gdGhlIHNj c2kgdHJlZXMsIGFuZA0KPiB3b3VsZCBoYXZlIG5lZWRlZCBzb21ldGhpbmcgZWxzZSBmcm9tIGxp bnV4LW5leHQgdG8gZXZlbiBjb21waWxlLiAgU28gSQ0KPiBkb24ndCB0aGluayB0aGUgcmV2ZXJ0 IGlzIGEgcHJvYmxlbSBhdCBhbGwsIGFuZCBJJ2xsIGFkZCBpdCB0byB0aGUNCj4gc2NzaS1mb3It My4yMCBicmFuY2ggQVNBUC4NCg0KQWN0dWFsbHksIG9uIHRoZSByZXZlcnQgb2YgDQoNCnNjc2k6 IHVmcy1xY29tLWljZTogYWRkIElubGluZSBDcnlwdG8gRW5naW5lIChJQ0UpIHN1cHBvcnQgZm9y IFVGUw0KDQpXaGljaCBpc24ndCB3aGF0IHRoaXMgcHJvYmxlbSBpcyAodGhlIGV4cG9ydHMgc3Rp bGwgbmVlZCBhZGRpbmcpLCBzaW5jZQ0KaXQncyBvbmx5IGluIHRoZSBtaXNjIHRyZWUsIGxldCdz IGp1c3QgZHJvcCB0aGUgcGF0Y2hlcyByYXRoZXIgdGhhbg0KZG9pbmcgYW4gYWRkIGFuZCByZXZl cnQuDQoNCkphbWVzDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbottomley@parallels.com (James Bottomley) Date: Mon, 2 Feb 2015 17:55:48 +0000 Subject: [PATCH] phy: qcom-ufs: export symbols needed by main drivers In-Reply-To: <20150202162648.GA20465@lst.de> References: <1840882.huchmEIh5K@wuerfel> <1422891069.2103.1.camel@parallels.com> <20150202162648.GA20465@lst.de> Message-ID: <1422899790.2103.11.camel@parallels.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2015-02-02 at 17:26 +0100, hch at lst.de wrote: > On Mon, Feb 02, 2015 at 03:30:27PM +0000, James Bottomley wrote: > > Cc added for linux-scsi, since this is the origin of the problem. How > > important is bisectability in this? It won't affect any non-embedded > > user, since most don't build with UFS, so I can go either way on folding > > or just applying as an extra patch. > > The CRYPTO_DEV_QCOM_ICE symbol was never defined in the scsi trees, and > would have needed something else from linux-next to even compile. So I > don't think the revert is a problem at all, and I'll add it to the > scsi-for-3.20 branch ASAP. Actually, on the revert of scsi: ufs-qcom-ice: add Inline Crypto Engine (ICE) support for UFS Which isn't what this problem is (the exports still need adding), since it's only in the misc tree, let's just drop the patches rather than doing an add and revert. James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932890AbbBBR4l (ORCPT ); Mon, 2 Feb 2015 12:56:41 -0500 Received: from mx2.parallels.com ([199.115.105.18]:47408 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932424AbbBBR4h (ORCPT ); Mon, 2 Feb 2015 12:56:37 -0500 From: James Bottomley To: "hch@lst.de" CC: "linux-arm-kernel@lists.infradead.org" , "dovl@codeaurora.org" , "ygardi@codeaurora.org" , "kishon@ti.com" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "linux-scsi@vger.kernel.org" Subject: Re: [PATCH] phy: qcom-ufs: export symbols needed by main drivers Thread-Topic: [PATCH] phy: qcom-ufs: export symbols needed by main drivers Thread-Index: AQHQOxYAusPBkOjK3UuAyRuGiZKAoJzeCnmAgAAPjACAABkQAA== Date: Mon, 2 Feb 2015 17:55:48 +0000 Message-ID: <1422899790.2103.11.camel@parallels.com> References: <1840882.huchmEIh5K@wuerfel> <1422891069.2103.1.camel@parallels.com> <20150202162648.GA20465@lst.de> In-Reply-To: <20150202162648.GA20465@lst.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [50.46.149.214] Content-Type: text/plain; charset="utf-8" Content-ID: <951A533B38FB4445B2A90C0C65CDE3A1@sw.swsoft.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t12HukBx004867 On Mon, 2015-02-02 at 17:26 +0100, hch@lst.de wrote: > On Mon, Feb 02, 2015 at 03:30:27PM +0000, James Bottomley wrote: > > Cc added for linux-scsi, since this is the origin of the problem. How > > important is bisectability in this? It won't affect any non-embedded > > user, since most don't build with UFS, so I can go either way on folding > > or just applying as an extra patch. > > The CRYPTO_DEV_QCOM_ICE symbol was never defined in the scsi trees, and > would have needed something else from linux-next to even compile. So I > don't think the revert is a problem at all, and I'll add it to the > scsi-for-3.20 branch ASAP. Actually, on the revert of scsi: ufs-qcom-ice: add Inline Crypto Engine (ICE) support for UFS Which isn't what this problem is (the exports still need adding), since it's only in the misc tree, let's just drop the patches rather than doing an add and revert. James {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I