From: Joe Perches <joe@perches.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: marcel@holtmann.org, gustavo@padovan.org,
johan.hedberg@gmail.com, "David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] bluetooth: hci_sock: Use type cast "(void *)" to avoid building warnings
Date: Mon, 02 Feb 2015 12:39:58 -0800 [thread overview]
Message-ID: <1422909598.30476.20.camel@perches.com> (raw)
In-Reply-To: <54CFE01D.5090309@sunrus.com.cn>
On Tue, 2015-02-03 at 04:37 +0800, Chen Gang S wrote:
> The related warning (with allmodconfig under xtensa):
[]
> diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
[]
> @@ -952,7 +952,7 @@ static int hci_sock_sendmsg(struct kiocb *iocb, struct socket *sock,
>
> if (((ogf > HCI_SFLT_MAX_OGF) ||
> !hci_test_bit(ocf & HCI_FLT_OCF_BITS,
> - &hci_sec_filter.ocf_mask[ogf])) &&
> + (void *)&hci_sec_filter.ocf_mask[ogf])) &&
> !capable(CAP_NET_RAW)) {
> err = -EPERM;
> goto drop;
Probably better to change the hci_test_bit to take const void *
static inline int hci_test_bit(int nr, void *addr)
{
return *((__u32 *) addr + (nr >> 5)) & ((__u32) 1 << (nr & 31));
}
next prev parent reply other threads:[~2015-02-02 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 20:37 [PATCH] bluetooth: hci_sock: Use type cast "(void *)" to avoid building warnings Chen Gang S
2015-02-02 20:37 ` Chen Gang S
2015-02-02 20:39 ` Joe Perches [this message]
2015-02-02 21:07 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422909598.30476.20.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gang.chen@sunrus.com.cn \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.