From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] docs: create reproducible html Date: Tue, 3 Feb 2015 10:54:24 +0000 Message-ID: <1422960864.9323.25.camel@citrix.com> References: <1422883377-719-1-git-send-email-olaf@aepfle.de> <21711.31749.119163.584459@mariner.uk.xensource.com> <20150202134018.GA5648@aepfle.de> <21711.32580.450202.752206@mariner.uk.xensource.com> <20150203092754.GA23320@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150203092754.GA23320@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-03 at 10:27 +0100, Olaf Hering wrote: > On Mon, Feb 02, Ian Jackson wrote: > > > There aren't any places in the Xen build system where the performance > > impact of sorting is relevant. > > No idea how much the gain was when automated sorting was removed from > make(1). > > > A rule that $(wildcard ) in Makefiles should always be accompanied by > > $(sort ) is simple, clear, easy to understand, and directly addresses > > the unpredictability at source. > > Ok, I will adjust the outstanding patches to that rule. Would a helper macro so we can just write $(call wildcard,arg arg arg) instead of $(sort $(wildcard arg arg arg)) be possible and/or useful? Ian.