From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 6/7] build system: stubdom targets now
 depends on mini-os target
Date: Tue, 3 Feb 2015 11:31:31 +0000
Message-ID: <1422963091.9323.45.camel@citrix.com>
References: <1422881943-7687-1-git-send-email-wei.liu2@citrix.com>
	<1422881943-7687-7-git-send-email-wei.liu2@citrix.com>
	<1422889304.4801.8.camel@citrix.com>
	<1422889425.4801.10.camel@citrix.com>
	<20150202171849.GB841@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150202171849.GB841@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: talex5@gmail.com, anil@recoil.org, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, pooka@iki.fi, samuel.thibault@ens-lyon.org, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-02-02 at 17:18 +0000, Wei Liu wrote:
> On Mon, Feb 02, 2015 at 03:03:45PM +0000, Ian Campbell wrote:
> > On Mon, 2015-02-02 at 15:01 +0000, Ian Campbell wrote:
> > > On Mon, 2015-02-02 at 12:59 +0000, Wei Liu wrote:
> > > > Provide mini-os url and revision in Config.mk
> > > > 
> > > > Introduce Makefile.mini-os which contains mini-os specific targets.
> > > 
> > > I'm not sure it has enough content to warrant that, those two targets
> > > could easily be inlined.
> > > 
> > > > +ifeq ($(wildcard $(MINI_OS)/Config.mk),)
> > > > +$(error Please run `make mini-os-dir' in top-level directory)
> > > > +endif
> > > 
> > > This makes me think that maybe my earlier suggestion to move the clone
> > > under stubdom/ might be better done right away.
> > > 
> > > In fact, that would avoid the need to play tricks with renaming extras/
> > > too, since you could build both for a commit.
> > 
> > Retracted after reponse to my earlier suggestion...
> > 
> 
> I take it you're fine with the current arrangement now?

I suppose "willing to tolerate" might be closer, but yes ;-)

Ian.